Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMS >= 0.10.3 : support ruby 2.4 #2004

Closed
kofronpi opened this issue Dec 16, 2016 · 8 comments
Closed

AMS >= 0.10.3 : support ruby 2.4 #2004

kofronpi opened this issue Dec 16, 2016 · 8 comments

Comments

@kofronpi
Copy link
Contributor

kofronpi commented Dec 16, 2016

Expected behavior vs actual behavior

active_model_serializers should support ruby 2.4 as its release candidate is live.
the json gem is an indirect dependency of ams, and json supports ruby 2.4.0 only >= 2.0.0

Steps to reproduce

Update Gemfile to ruby 2.4 and bundle install or bundle update json

Environment

ActiveModelSerializers Version 0.10.3
Output of ruby -e "puts RUBY_DESCRIPTION": ruby 2.4.0rc1 (2016-12-12 trunk 57064) [x86_64-linux]
OS Type & Version: Ubuntu 16.04
Integrated application and version : Rails 5.0.1.rc2

Backtrace

When running bundle update json:

$ bundle update json
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Bundler could not find compatible versions for gem "json":
  In Gemfile:
    json (~> 2.0.1)

    active_model_serializers (~> 0.10.3) was resolved to 0.10.3, which depends on
      jsonapi (= 0.1.1.beta2) was resolved to 0.1.1.beta2, which depends on
        json (~> 1.8)

Additonal helpful information

The jsonapi gem fixed this in a later beta release.

Thanks !

@kofronpi kofronpi changed the title Support ruby 2.4 AMS >= 0.10.3 : support ruby 2.4 Dec 16, 2016
@beauby
Copy link
Contributor

beauby commented Dec 16, 2016

@kofronpi Sorry, I replied in the other thread (and I mistakenly suggested that not pinning json to post 2.0 in your Gemfile would fix your issue).

Bottom line: AMS should depend on jsonapi v0.1.1.beta6.

@meoooh
Copy link

meoooh commented Dec 26, 2016

@beauby Can I know that this when patch is uploaded to rubygems.org?

@bf4
Copy link
Member

bf4 commented Dec 27, 2016

@meoooh Currently blocked by regression in #1998 unless we make a 0.10 branch that doesn't have everything in it that's in master...

@9mm
Copy link

9mm commented Dec 27, 2016

Definitely interested in this, saving for later (I just tried to update my project to ruby 2.4.0, rails 5)

@dreyks
Copy link

dreyks commented Dec 30, 2016

master branch works fine for me

@grosser
Copy link

grosser commented Dec 30, 2016

I'd love to have a release that works out of the box ... maybe just got back to the latest tag and release from a branch ?

@bf4
Copy link
Member

bf4 commented Dec 30, 2016 via email

@kofronpi
Copy link
Contributor Author

Merged in >= 0.10.4 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants