-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMS >= 0.10.3 : support ruby 2.4 #2004
Comments
@kofronpi Sorry, I replied in the other thread (and I mistakenly suggested that not pinning Bottom line: AMS should depend on |
@beauby Can I know that this when patch is uploaded to rubygems.org? |
Definitely interested in this, saving for later (I just tried to update my project to ruby 2.4.0, rails 5) |
master branch works fine for me |
I'd love to have a release that works out of the box ... maybe just got back to the latest tag and release from a branch ? |
I think we/I might just do that when I get back from holiday.
B mobile phone
… On Dec 30, 2016, at 1:53 PM, Michael Grosser ***@***.***> wrote:
I'd love to have a release that works out of the box ... maybe just got back to the latest tag and release from a branch ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Merged in >= 0.10.4 💛 |
Expected behavior vs actual behavior
active_model_serializers
should support ruby 2.4 as its release candidate is live.the
json
gem is an indirect dependency ofams
, andjson
supports ruby 2.4.0 only>= 2.0.0
Steps to reproduce
Update Gemfile to ruby 2.4 and bundle install or
bundle update json
Environment
ActiveModelSerializers Version
0.10.3
Output of
ruby -e "puts RUBY_DESCRIPTION"
: ruby 2.4.0rc1 (2016-12-12 trunk 57064) [x86_64-linux]OS Type & Version: Ubuntu 16.04
Integrated application and version : Rails
5.0.1.rc2
Backtrace
When running
bundle update json
:Additonal helpful information
The
jsonapi
gem fixed this in a later beta release.Thanks !
The text was updated successfully, but these errors were encountered: