Empty collection root key from explicit serializer option #1618
Conversation
| @@ -182,7 +182,7 @@ def as_json(adapter_opts = nil) | |||
|
|
|||
| # Used by adapter as resource root. | |||
| def json_key | |||
| root || object.class.model_name.to_s.underscore | |||
| root || _type || object.class.model_name.to_s.underscore | |||
There was a problem hiding this comment.
not required in this PR, but makes sense
| @@ -182,7 +182,7 @@ def as_json(adapter_opts = nil) | |||
|
|
|||
| # Used by adapter as resource root. | |||
| def json_key | |||
There was a problem hiding this comment.
Thinking about it now, shouldn't it be the responsibility of the adapter to determine the json key/root?
There was a problem hiding this comment.
it does, but it uses information from the serializer....
There was a problem hiding this comment.
From what I see, we can set the root as adapter option and call serializer._type and serializer.object.class.model_name.to_s.underscore from the adapter. Same goes for collection_serializer. What do you think?
|
Great job! The PR looks good. I'll be ok to merge it once the rubocop is fixed. |
…ed to collection serializer and each_searializer is specified.
bf4
force-pushed
the
RomanKapitonov-master
branch
from
e5c4ac1 to
a74d174
Compare
|
Running |
| @@ -3,6 +3,10 @@ | |||
| module ActiveModel | |||
| class Serializer | |||
| class CollectionSerializerTest < ActiveSupport::TestCase | |||
| MessagesSerializer = Class.new(ActiveModel::Serializer) do | |||
There was a problem hiding this comment.
We should align on Class.new(ActiveModel::Serializer) vs class Name; end.
|
Merging when the build is done 😉 |
Fixes #1617
Closes #1537
json_keyuses_typewhen root not givenbefore falling back on object class
Array instances.