Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaitBlocksTask should show progress in the UI #312

Open
rakanalh opened this issue Sep 11, 2019 · 2 comments
Open

WaitBlocksTask should show progress in the UI #312

rakanalh opened this issue Sep 11, 2019 · 2 comments
Labels
Feature request A request for a new SP feature

Comments

@rakanalh
Copy link
Contributor

The scenario player currently only shows:

│2019-09-11 12:47:16.701089 [info     ] Starting task                  [scenario_player.tasks.base] task=<WaitBlocksTask: 401> 

However, i think it would be pretty nice to show the current block number, which gets updated after each block is created so that the task's progress can be seen.

@rakanalh rakanalh added the Feature request A request for a new SP feature label Sep 11, 2019
@ulope
Copy link
Contributor

ulope commented Sep 12, 2019

Good idea, should maybe not log every block though (otherwise the various 401 block waits will create a log of log spam).
Maybe only log every blocks_to_wait / 10 blocks if blocks_to_wait > 15 or something like that?

@rakanalh
Copy link
Contributor Author

Maybe we shouldn't log anything. The task is marked "in progress" in the list of tasks. Maybe we can place an addition to the label saying "(X / 401)"

@christianbrb christianbrb added this to the Product Backlog milestone Oct 29, 2019
@christianbrb christianbrb changed the title WaitBlocksTask should show progress WaitBlocksTask should show progress in the UI Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request A request for a new SP feature
Projects
None yet
Development

No branches or pull requests

3 participants