Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests also with parity client #236

Open
LefterisJP opened this issue Aug 15, 2019 · 1 comment
Open

Run tests also with parity client #236

LefterisJP opened this issue Aug 15, 2019 · 1 comment
Labels
Feature request A request for a new SP feature

Comments

@LefterisJP
Copy link
Contributor

Analysis

Current State

Currently all tests in the SP run only with geth.

Problem

We should also run them with parity since parity is also heavily utilized out there and has quite a few differences with geth which lead to bugs in the raiden implementation.

Solution

Either run all scenarios in the SP both with parity and geth (may be a bit too much)
or randomly assign a client and use it for the scenario. This way over a long period of time we get enough coverage of both clients.

@LefterisJP LefterisJP added the Feature request A request for a new SP feature label Aug 15, 2019
@deepbrook
Copy link

I would actually run all of them against both clients - randomly selecting clients doesn't seem sensible. That way, every other day a test failure would pop up and disappear the next time the scenarios are run.

Running them against both clients isn't a lot of trouble to implement. I would, however, wait for the concurrent run feature to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request A request for a new SP feature
Projects
None yet
Development

No branches or pull requests

2 participants