Don't install pyinstaller and s3cmd in jobs that don't need it #3308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will also probably circumvent the pip 19.0 pyinstaller [bug](pypa/pip#6163) that hit us in all Travis jobs. Example: https://travis-ci.org/raiden-network/raiden/jobs/483407811
Codecov Report
@@ Coverage Diff @@
## master #3308 +/- ##
==========================================
+ Coverage 74.79% 74.82% +0.02%
==========================================
Files 94 94
Lines 12165 12165
Branches 1689 1689
==========================================
+ Hits 9099 9102 +3
+ Misses 2441 2439 -2
+ Partials 625 624 -1
Continue to review full report at Codecov.
|
rakanalh
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will also probably circumvent the pip 19.0 pyinstaller
bug that hit us in all
Travis jobs. Example: https://travis-ci.org/raiden-network/raiden/jobs/483407811