Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that was never needed.
This fixes #1262
What this PR does
This PR removes two lines that initialized variables with
None
.Why I'm making this PR
I saw somewhere else
mypy
complain that these variables might beNone
. (When I was implementing #1257).What's tricky about this PR (if any)
Nothing.
Any reviewer can check these:
make compile_contracts
and add the resultingraiden_contracts/data/contracts.json
in the PR.[skip ci]
in the commit message so Travis does not waste time.[skip ci]
and let Travis check the hash of the source.solidityFunction
_solidity_argument
solidity_variable
python_variable
PYTHON_CONSTANT
etherscan_verify.py
runs on the new contract.gas.json
.pytest.raises(TransactionFailed, match="error message"):
And before "merge" all checkboxes have to be checked. If you find redundant points, remove them.