Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a feature to check that a Solidity source did not change #1257

Open
pirapira opened this issue Oct 2, 2019 · 2 comments
Open

Implement a feature to check that a Solidity source did not change #1257

pirapira opened this issue Oct 2, 2019 · 2 comments
Labels
P1 urgent, blocker, or makes life easier forever

Comments

@pirapira
Copy link
Contributor

pirapira commented Oct 2, 2019 •
edited
Loading

We have to get make compile_contracts fail when the source of SecretRegistry changes. For that we need a command that compares Soldity sources against an entry in contracts.json.

contracts.json contains "contract_checksums". This sounds useful for the purpose.

This issue can be closed when ContractSourceManager has a new method for this purpose.
@pirapira pirapira added the question Further information is requested label Oct 2, 2019
@pirapira pirapira mentioned this issue Oct 2, 2019
Open
@pirapira
Copy link
Contributor Author

pirapira commented Oct 2, 2019

ContractSourceManager.verify_precompiled_checksums() does it, but only for all contracts at once.

In #1208, we need this feature only for SecretRegistry. We need a new method that verifies the checksum only for a specific contract.

@pirapira pirapira added P1 urgent, blocker, or makes life easier forever and removed question Further information is requested labels Oct 2, 2019
@pirapira pirapira self-assigned this Oct 2, 2019
@pirapira

This comment has been minimized.

Sign in to view
@pirapira pirapira mentioned this issue Oct 2, 2019
Merged
15 tasks
@pirapira pirapira changed the title How to check Solidity sources didn't change? Implement a feature to check that a Solidity source did not change Oct 22, 2019
pirapira added a commit to pirapira/raiden-contracts that referenced this issue Oct 22, 2019
@pirapira
Separate _verify_single_precompiled_checksum()
595efcb 
This commit separates a function that checks one entry of
contracts.json.  This eases the implementation of raiden-network#1257.
@pirapira pirapira mentioned this issue Oct 22, 2019
Merged
4 tasks
pirapira added a commit to pirapira/raiden-contracts that referenced this issue Oct 22, 2019
@pirapira
Separate _verify_single_precompiled_checksum()
73aaa34 
This commit separates a function that checks one entry of
contracts.json.  This eases the implementation of raiden-network#1257.
pirapira added a commit to pirapira/raiden-contracts that referenced this issue Oct 22, 2019
@pirapira
Separate _verify_single_precompiled_checksum()
2fa885b 
This commit separates a function that checks one entry of
contracts.json.  This eases the implementation of raiden-network#1257.
pirapira added a commit to pirapira/raiden-contracts that referenced this issue Oct 22, 2019
@pirapira
Separate _verify_single_precompiled_checksum()
5d1d154 
This commit separates a function that checks one entry of
contracts.json.  This eases the implementation of raiden-network#1257.
pirapira added a commit to pirapira/raiden-contracts that referenced this issue Oct 25, 2019
@pirapira
Separate _verify_single_precompiled_checksum()
945b58d 
This commit separates a function that checks one entry of
contracts.json.  This eases the implementation of raiden-network#1257.
pirapira added a commit to pirapira/raiden-contracts that referenced this issue Oct 31, 2019
@pirapira
Separate _verify_single_precompiled_checksum()
523b35d 
This commit separates a function that checks one entry of
contracts.json.  This eases the implementation of raiden-network#1257.
pirapira added a commit that referenced this issue Oct 31, 2019
@pirapira
Separate _verify_single_precompiled_checksum()
84aaac0 
This commit separates a function that checks one entry of
contracts.json.  This eases the implementation of #1257.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 urgent, blocker, or makes life easier forever
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pirapira