Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A feature to skip compilation of SecretRegistry #1208

Open
pirapira opened this issue Aug 30, 2019 · 2 comments
Open

A feature to skip compilation of SecretRegistry #1208

pirapira opened this issue Aug 30, 2019 · 2 comments
Labels
efforts: a few days hack P1 urgent, blocker, or makes life easier forever

Comments

@pirapira
Copy link
Contributor

When we upgrade the Solidity compiler #1155 but want to keep an old compilation of SecretRegistry, we need a feature where contracts except SecretRegistry is compiled.

This issue keeps track of implementing such a partial compilation.
@pirapira pirapira added P1 urgent, blocker, or makes life easier forever efforts: a few days hack labels Aug 30, 2019
@pirapira pirapira mentioned this issue Aug 30, 2019
Closed
@pirapira pirapira self-assigned this Oct 2, 2019
@pirapira
Copy link
Contributor Author

pirapira commented Oct 2, 2019

One way of doing it: make compile_contracts does not compile SecretRegistry, and checks that the source code of SecretRegistry did not change.

@pirapira
Copy link
Contributor Author

pirapira commented Oct 2, 2019

I need to figure out how to detect source changes #1257.

@pirapira pirapira mentioned this issue Oct 2, 2019
Open
@pirapira pirapira mentioned this issue Oct 22, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
efforts: a few days hack P1 urgent, blocker, or makes life easier forever
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pirapira