Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intrduce a type to group bundle addresses #1085

Open
hackaugusto opened this issue Jun 24, 2019 · 1 comment
Open

Intrduce a type to group bundle addresses #1085

hackaugusto opened this issue Jun 24, 2019 · 1 comment
Labels

Comments

@hackaugusto
Copy link
Contributor

Add a new class to group smart contract addresses know to work together. And return an instance of this class instead of a dictionary in get_contracts_deployment_info. The goal here is to have proper type checking for the addresses.

If there are ABI breakage, a new class should be introduced (this will break the state linting on Raiden and force us to fix the corresponding proxies). I

@pirapira
Copy link
Contributor

pirapira commented Jun 27, 2019

The said dictionary is somewhat typed. This issue boils down to giving a more precise type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants