Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supplying only a hash includes the pathname #96

Open
thany opened this issue Mar 11, 2022 · 1 comment
Open

Supplying only a hash includes the pathname #96

thany opened this issue Mar 11, 2022 · 1 comment

Comments

@thany
Copy link

thany commented Mar 11, 2022

Suppose this link on the, I dunno, the /contact page:

<HashLink to="#top">Top</HashLink>

This will produce:

<a href="/contact#top">Top</a>

What's that /contact doing there? It's not supposed to be there. I didn't specify a link to the current page, but only to a hash.

To reproduce:

  1. Go to the demo.
  2. Scroll down to the Top of Page link, and inspect its attributes.
  3. Observe its href attribute being /page#top.
  4. Now go to the source.
  5. Scroll down and find the same link.
  6. Observe how it only has to="#top" and nothing else as far as urls are concerned.
@blackr1234
Copy link

Looks like this issue is no longer there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants