-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it work with react router v6 #92
Comments
Added support for custom link as well but with breaking changes, GenericHashLink. |
Does it need to be bumped all the way to React v17? RRDv6 still supports any version of React compatible with hooks, i.e.
|
Oh, did not check. Well my fork is using typescript and I don,t know if you still want keep plain js. If you have any plan to migrate you can base it on my code if you find it okey and change the dependency as well. |
Bumping this as an issue. Doing a bit of research on using anchor hash links with react-router-dom v6 and looks like they have no plan to implement this functionality into the library by default so |
It's on my list, but it might be a little while before I get to it. |
The definition of NavLink.isActive has been changed in V6, please refer to |
In my fork it can be used like this,
|
The scroll on this and the forked version does not work across all browsers on mobiles. Works fine on desktops. Any ideas? |
Hey all. Working with React-Router V6, I define my routes like
Currently the |
I use react router v6, so works well i use react router has link |
I've built a component that solves this problem passively in the background without having to modify any react-router Links. |
thanks for sharing @ncoughlin ! worked like a charm. |
Hi, would be nice with a version for v6.
I made a fork but backwards compatibility is lost and at the moment custom link is gone.
The text was updated successfully, but these errors were encountered: