Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fennel snippets completely broken #152

Closed
monkoose opened this issue May 11, 2022 · 5 comments · Fixed by #159
Closed

Fennel snippets completely broken #152

monkoose opened this issue May 11, 2022 · 5 comments · Fixed by #159
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@monkoose
Copy link

monkoose commented May 11, 2022

For some reason they slow down nvim-cmp (when you select the snippet in cmp popup window there can be some huge delay 100+ms).

And even without delay snippets are useless, they just paste irrelevant text without any jump labels.
So as example

  "var": {
    "prefix": "var",
    "body": "var name value)",
    "description": "Create a variable with var"
  },

should be something like

  "var": {
    "prefix": "var",
    "body": "var ${1:name} ${2:value})$0",
    "description": "Create a variable with var"
  },

EDIT: ok, seems like delay happens on the nvim-cmp or luasnip side, because even global snippets in fennel files add delay to switching between suggestions in the popup window.

@bryant-the-coder
Copy link
Collaborator

@OkelleyDevelopment

@OkelleyDevelopment
Copy link
Collaborator

OkelleyDevelopment commented May 14, 2022

I don't notice any issues with load times however, I do agree that the snippets are a little off. I can come back to this after I finish working on a solution for issue #105 though. Anyone else can feel free to make a PR for us to review if they want to speed the process up.

Edit: 😎

@OkelleyDevelopment OkelleyDevelopment added bug Something isn't working good first issue Good for newcomers labels May 14, 2022
@OkelleyDevelopment OkelleyDevelopment self-assigned this Jun 1, 2022
@OkelleyDevelopment OkelleyDevelopment added In progress and removed good first issue Good for newcomers labels Jun 1, 2022
@OkelleyDevelopment
Copy link
Collaborator

@monkoose Hello 👋

Just opened a PR with some updates to the snippet formatting that you can check out if you wish.

With regards to the load delays, that is (as you have guessed) not something that is likely caused by this project in particular. I know from my own set up, the order in which I had snippets load can affect how nicely it loads

i.e. Check how you have nvim-cmp configured for source order as that might resolve the delays 👀

@OkelleyDevelopment OkelleyDevelopment linked a pull request Jun 6, 2022 that will close this issue
@OkelleyDevelopment OkelleyDevelopment added question Further information is requested and removed In progress labels Jun 6, 2022
@andrejcesen
Copy link

Hey @monkoose, curious if you ever figured out what was the reason behind the slowdown? I'm facing the same delay when toggling between Fennel snippets in the popup.

@monkoose
Copy link
Author

@andrejcesen Hello. Sorry didn't figure it out. So I just disabled them for fennel filetypes.
If you will ever find the solution let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants