Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree-shaking is broken in "next" release #1428

Closed
benoitgrelard opened this issue May 26, 2022 · 2 comments · Fixed by #1483
Closed

Tree-shaking is broken in "next" release #1428

benoitgrelard opened this issue May 26, 2022 · 2 comments · Fixed by #1483
Assignees
Labels
Type: Bug Confirmed bug

Comments

@benoitgrelard
Copy link
Collaborator

#1424

Following the above discussion, I was doing some testing around tree-shaking and it looks like the @latest is able to tree-shake a bit, but the @next isn't so we must have broken something.

I suspect perhaps it's got something to do to the parcel upgrade.

@benoitgrelard benoitgrelard added Type: Bug Confirmed bug Priority: High High priority issue React: 18 Issue with React 18 Resolution: Needs Investigation This issue needs more investigation Package: react/select labels May 26, 2022
@benoitgrelard benoitgrelard added this to the Release: Agile Halo milestone May 26, 2022
@benoitgrelard benoitgrelard self-assigned this May 26, 2022
@benoitgrelard benoitgrelard removed Priority: High High priority issue React: 18 Issue with React 18 Resolution: Needs Investigation This issue needs more investigation Package: react/select labels May 26, 2022
@benoitgrelard benoitgrelard removed their assignment May 26, 2022
@andy-hook
Copy link
Collaborator

Might be worth entertaining a spike on parcel alternative if this ends up looking tricky to resolve at the tooling level (similar to #1332)

@benoitgrelard benoitgrelard self-assigned this Jun 7, 2022
@benoitgrelard
Copy link
Collaborator Author

After some research, determined this is likely a change in Parcel2.
Opened an issue there: parcel-bundler/parcel#8216

This section of the docs seems to suggest perhaps it isn't supported: https://parceljs.org/features/scope-hoisting/#side-effects

However, if export * had been used instead, this would not be true because Parcel would not know what exports are available.

This comment also potentially hints at it: parcel-bundler/parcel#4565 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Confirmed bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants