Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rad download version in samples tests workflow #1578

Open
vishwahiremat opened this issue Jun 24, 2024 · 1 comment
Open

Update rad download version in samples tests workflow #1578

vishwahiremat opened this issue Jun 24, 2024 · 1 comment
Labels
bug Something is broken or not working as expected triaged This item has been triaged by project maintainers and is in the backlog

Comments

@vishwahiremat
Copy link
Contributor

vishwahiremat commented Jun 24, 2024

Today we run scheduled samples workflow on the release branch but the radius version downloaded as part of the workflow default to edge. which mean if there are breaking changes in edge the pipeline runs starts failing until next release is out. Here is an example of the issue we came across when we had breaking changes in 0.35 and workflow on 0.34 started failing until we have 0.35 release out.

Proposed Solution:
Update the Download rad cli step to download the release version when workflow is running on a release branch.

@vishwahiremat vishwahiremat added the bug Something is broken or not working as expected label Jun 24, 2024
@vishwahiremat vishwahiremat changed the title Samples workflow fails on Release branch when there are breaking changes on edge. Update rad download version in samples tests workflow Jun 27, 2024
@nicolejms nicolejms added the triaged This item has been triaged by project maintainers and is in the backlog label Jun 27, 2024
@nicolejms
Copy link

Change in samples test workflow to pull correct version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken or not working as expected triaged This item has been triaged by project maintainers and is in the backlog
Projects
None yet
Development

No branches or pull requests

2 participants