Add a mask-setter property #869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to set the mask attribute but being blocked from doing so
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #869 +/- ##
==========================================
- Coverage 77.36% 77.36% -0.01%
==========================================
Files 24 24
Lines 6027 6030 +3
==========================================
+ Hits 4663 4665 +2
- Misses 1364 1365 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I'm going to merge this into #854 and try to resolve everything there |
|
@keflavich good to close this in favour of #854? |
Merged
|
Yep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error:
https://github.com/radio-astro-tools/spectral-cube/actions/runs/4375133747/jobs/7655452694#step:5:2644
may be caused by not having a settable mask.
We really need to resolve this with the #808 refactor, but I want passing tests as a stopgap