Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beams returns array of arbitrary length #721

Open
keflavich opened this issue Jun 4, 2021 · 1 comment
Open

beams returns array of arbitrary length #721

keflavich opened this issue Jun 4, 2021 · 1 comment

Comments

@keflavich
Copy link
Contributor

The beams returned with .beams can be smaller than the spectral axis shape, which probably isn't what we want:

@property
def beams(self):
return self._beams[self.goodbeams_mask]

I think we should instead be returning a masked array. Any thoughts on how we should do this? Is the Beams object actually compatible with being masked in that way?

@e-koch
Copy link
Contributor

e-koch commented Jun 15, 2021

Not currently, but a masked array seems necessary for this reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants