You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As I was looking at the beam code for astropy/astropy#17096, I noticed a few oddities in Beam. Mostly that it inherits from Quantity, which I'm not sure is a good idea given that some basic methods are overwritten and many others would not work (e.g., you'd need a proper __array_finalize__ to deal with slicing, etc.; right now, you'd lose the extra attributes with you do beam[()]). If there are real advantages to using Beam, I'd recommend using SpecificTypeQuantity.
A second thing I happened to notice is that default_unit is not actually used as described in the docstring.
Anyway, just flyby comments - hopefully of some use.
The text was updated successfully, but these errors were encountered:
As I was looking at the
beam
code for astropy/astropy#17096, I noticed a few oddities inBeam
. Mostly that it inherits fromQuantity
, which I'm not sure is a good idea given that some basic methods are overwritten and many others would not work (e.g., you'd need a proper__array_finalize__
to deal with slicing, etc.; right now, you'd lose the extra attributes with you dobeam[()]
). If there are real advantages to usingBeam
, I'd recommend usingSpecificTypeQuantity
.A second thing I happened to notice is that
default_unit
is not actually used as described in the docstring.Anyway, just flyby comments - hopefully of some use.
The text was updated successfully, but these errors were encountered: