Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python setup.py develop is broken #1197

Closed
robnagler opened this issue May 19, 2018 · 1 comment
Closed

python setup.py develop is broken #1197

robnagler opened this issue May 19, 2018 · 1 comment

Comments

@robnagler
Copy link
Member

I'm working on fixing setup.py -- thanks to pip removing all public APIs, see radiasoft/pykern#23.

python setup.py develop (in testing) fails with:

Installed /home/vagrant/.pyenv/versions/2.7.14/envs/py2/lib/python2.7/site-packages/Flask_SQLAlchemy-2.3.2-py2.7.egg
error: The 'Flask' distribution was not found and is required by Flask-OAuthlib

However, pip install -e . works fine. I think this is due install_requires differences.

install_requires does not support git+ references. They added dependency_links, but they are removing those. I think we'll have some references in requirements.txt and others in install_requires, because nobody seems to know what to do with these git+ links.

In the end, the install scripts will just work, and that will be fine.

@robnagler
Copy link
Member Author

There's no way to fix python setup.py develop to work right with a git+git reference. afaict python setup.py does not read requirements.txt. It was only working because requirements.txt was being read by pksetup and put in install_requires, but the git+git dependencies were getting stripped out.

Lots of discussion about this:

Note that dependency_links is going away. I don't know the solution, frankly, but having some deps in requirements.txt is good enough. The rest should be install_requires.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant