Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wavelengths in eo:bands examples #1238

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

christophfriedrich
Copy link
Contributor

@christophfriedrich christophfriedrich commented Jul 3, 2023

According to the spec of the eo extension, the center_wavelength is given in micrometers (µm), but the examples sometimes contained them in nanometers (extended-item.json) or tens of nanometers (in "collection-only" folder; interestingly there from B10 upwards it was already correct).

Related Issue(s): Instead of opening an issue first, I just plunged forward and fixed it straight away.

Proposed Changes:

  1. Fix example files

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • a CHANGELOG entry is not required.
  • This PR affects the STAC API spec,
    and I have opened issue/PR #XXX to track the change.

Edit: Add link to eo docs

According to the spec of the `eo` extension, the `center_wavelength` is given in micrometers (µm), but the examples sometimes contained them in nanometers (extended-item.json) or tens of nanometers (in "collection-only" folder; interestingly there from B10 upwards it was already correct).
To make the validator happy
@philvarner philvarner merged commit b1dce7f into radiantearth:dev Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants