Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema responses to catalog api #30

Closed
cholmes opened this issue Nov 8, 2017 · 7 comments
Closed

Add schema responses to catalog api #30

cholmes opened this issue Nov 8, 2017 · 7 comments
Milestone

Comments

@cholmes
Copy link
Contributor

cholmes commented Nov 8, 2017

Add the mechanism to return the json schema for the returned data to the swagger API

@cholmes cholmes added this to the 0.3.0 milestone Nov 8, 2017
@cholmes
Copy link
Contributor Author

cholmes commented Nov 8, 2017

@joshfix - where did we end up with https://github.com/radiantearth/stac-spec/blob/dev/proposed/core-api-schema.yaml ?

I think maybe we should wait on @lossyrob with the static catalog, to make sure things are in line, and I can't remember if we're doing a schema there. But seems like a sensible thing to have.

@joshfix
Copy link
Contributor

joshfix commented Nov 10, 2017

@cholmes this was a contribution by Ryan. There was some discussion about how much schema info should be included in actual responses from the api, if any, and I'm not entirely sure we had a consensus, but we left it with this. Basically if you want schema info, you need to hit the schema endpoint. There hasn't been any review of this document whatsoever, but I'm happy to wait and update this with what comes out of the static catalog schema.

Side note, why wouldn't we have a schema for the static catalog?

@osialr
Copy link
Collaborator

osialr commented Nov 13, 2017

I put in the schema types as a starting point on discussion. However, I think JsonSchema can express a lot (all?) of what I was aiming for. We could change that part to simply say "returns schema as JsonSchema version X"

@cholmes cholmes modified the milestones: 0.3.0, future Mar 14, 2018
@cholmes
Copy link
Contributor Author

cholmes commented Mar 14, 2018

Moving this to a 'future' milestone. With alignment with WFS this should likely just be a reference to how WFS does JSON schema, or does this with OpenAPI, but I'm not sure if that's locked in yet.

cc @cportele - Is there a section of WFS spec yet on the openapi stuff you were talking about? And like the 'schema' extension? I think for STAC we'll pick just one way to do it.

@cportele
Copy link

@cholmes - The related schema issues are/were discussed here:

@m-mohr
Copy link
Collaborator

m-mohr commented Jul 18, 2019

Is this still relevant? WFS asks for an optional link only (see opengeospatial/ogcapi-features#236).

@matthewhanson
Copy link
Collaborator

I don't think this is relevant anymore. We should stick with whatever WFS does.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants