Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches get silently overridden on package update / native compilation #62

Open
sebmiq opened this issue Jun 22, 2022 · 2 comments
Open

Comments

@sebmiq
Copy link

sebmiq commented Jun 22, 2022

Hi,

A few of my patches keep getting silently overridden, I assume because the original definition is reevaluated by native compilation.

Using advice as suggested in #60 would be one way to fix this, perhaps.

@raxod502
Copy link
Member

Yes, that's a known issue. There are reasons to stick to the existing way of doing things, as mentioned in #60 (comment), but I suppose it would not be a bad idea to at least make it customizable whether the user would prefer for functions to be patched using advice rather than being overwritten.

@haji-ali
Copy link
Contributor

See #63 for a possible implementation and further discussion on the pitfalls of advising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants