Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftyUserDefaults.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion. #173

Closed
gabors opened this issue Feb 18, 2019 · 12 comments
Labels

Comments

@gabors
Copy link

gabors commented Feb 18, 2019

Hi guys

Tried the latest release, commit github "radex/SwiftyUserDefaults" "f7878b0ae7b39dee85df6cf60b4d361af327e654", integrated via Carthage

Getting this when uploading to AppStoreConnect, just FYI

This bundle Payload/<myapp>.app/Frameworks/SwiftyUserDefaults.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion.

@sunshinejr
Copy link
Owner

Hey @gabors, thanks for the heads-up! Is this a warning or an error?

@gabors
Copy link
Author

gabors commented Feb 18, 2019

No worries and thank you for an excellent framework.

This is an error, sometimes it gets caught by the Application loader, and once upload to ASC worked but the processing on Apple side failed and the email with the message above arrived.

@sunshinejr
Copy link
Owner

Okay, thanks! If you want to poke around and see if you can fix it and make a PR - it would be awesome. If not, I will take a look at it tomorrow, so no worries.

@sunshinejr
Copy link
Owner

@gabors could you check PR #174 and see if the error goes away? Would appreciate that before merging and releasing a new version!

@sunshinejr
Copy link
Owner

@gabors I've merged this one into the master, gonna release 4.0.0-alpha.3 in a sec as well. Please let me know once you try it out!

@gabors
Copy link
Author

gabors commented Feb 20, 2019

@sunshinejr Thanks very much, I'll try to build/upload to TestFlight and report back!

@gabors
Copy link
Author

gabors commented Feb 25, 2019

@sunshinejr I've tried a few TestFlight / AppStoreConnect uploads using
github "radex/SwiftyUserDefaults" "cc1519f3fc88f8955b35ca15d9d316d15b317ea7"

Unfortunately the apps failed processing:

We identified one or more issues with a recent delivery for your app. Please correct the following issues, then upload again.

Invalid Bundle - One or more dynamic libraries that are referenced by your app are not present in the dylib search path.

Invalid Bundle - The app uses Swift, but one of the binaries could not link to it because it wasn't found. Check that the app bundles correctly embed Swift standard libraries using the "Always Embed Swift Standard Libraries" build setting, and that each binary which uses Swift has correct search paths to the embedded Swift standard libraries using the "Runpath Search Paths" build setting.

@sunshinejr
Copy link
Owner

@gabors okay that’s a different one then. Are you sure you did setup the framework correcty? If you use Carthage, you might’ve skipped adding the input/output to your build phase maybe?

@gabors
Copy link
Author

gabors commented Feb 25, 2019

Yeah I’m using Carthage but the integration works fine with the prior version of this framework.

@sunshinejr
Copy link
Owner

Okay then. Could you please try this branch and see if it makes a difference?

@sunshinejr
Copy link
Owner

@gabors I've played with @rpath and updated it to support macOS/iOS better. After archiving it seems that the path for linker is correctly resolved so if you'd have a chance to use fix/carthage_linking branch it would be awesome.

@sunshinejr
Copy link
Owner

Alright, released version 4.0.0-beta.2 with regenerated project that should fix the linking issue now. Let me know once you'll have some time to test it out @gabors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants