Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Mingw32/Mingw64 support #9973

Closed
XVilka opened this issue Apr 28, 2018 · 26 comments
Closed

Remove the Mingw32/Mingw64 support #9973

XVilka opened this issue Apr 28, 2018 · 26 comments
Labels
FEEDBACK WANTED refactor Windows Microsoft Windows platform support issues

Comments

@XVilka
Copy link
Contributor

XVilka commented Apr 28, 2018

Since we now have native MSVC support it is just an additional burden to support Mingw32/64, and some code can be cleaned. So please discuss. And MSVC 2015 version supports Windows versions higher than Windows XP (including it).

@XVilka XVilka added FEEDBACK WANTED refactor Windows Microsoft Windows platform support issues labels Apr 28, 2018
@xarkes
Copy link
Contributor

xarkes commented Apr 28, 2018

I agree, I see no advantages to keep MinGW while MSVC is available.

@radare
Copy link
Collaborator

radare commented Apr 28, 2018 via email

@xarkes
Copy link
Contributor

xarkes commented Apr 28, 2018

Well indeed, but give me one good reason to cross compile when there are releases binaries? If you don't have Windows, you surely don't need Windows binaries?

@XVilka
Copy link
Contributor Author

XVilka commented Apr 28, 2018

@radare easy - just use Wine: https://github.com/xantares/msvc-wine

@radare
Copy link
Collaborator

radare commented Apr 28, 2018 via email

@XVilka
Copy link
Contributor Author

XVilka commented Apr 28, 2018 via email

@radare
Copy link
Collaborator

radare commented Apr 28, 2018 via email

@xarkes
Copy link
Contributor

xarkes commented Apr 28, 2018

Because no one needed it until you today :p
So if we add that to r2pm and documentation to cross compile with wine, then it's all good, we can remove MinGW support?

@radare
Copy link
Collaborator

radare commented Apr 28, 2018 via email

@radare
Copy link
Collaborator

radare commented Apr 28, 2018 via email

@XVilka
Copy link
Contributor Author

XVilka commented Apr 29, 2018 via email

@radare
Copy link
Collaborator

radare commented Apr 29, 2018 via email

@pelijah
Copy link
Contributor

pelijah commented Apr 29, 2018

Windows Subsystem for Linux. But it is available only on Windows 10.

@TheAifam5
Copy link

TheAifam5 commented May 9, 2018

What about Clang? :) We can use a clang and stuff from MinGW like headers and libraries.

@xarkes
Copy link
Contributor

xarkes commented May 9, 2018

You can use clang with meson+ninja build system. Just do set CC=clang and follow the instructions for building.

@pelijah
Copy link
Contributor

pelijah commented May 9, 2018

Meson doesn't support clang on Windows.

@thestr4ng3r
Copy link
Contributor

If you want to cross compile, couldn't you just use meson? It has support for that built in already, so if we drop support for mingw in acr it would still be possible without us having to maintain anything. (except maybe details in the source code that may be incompatible with mingw).

@virteman
Copy link

I don't agree this suggestion. on the contrary, radare should support Mingw32/Mingw64 and cygwin better.

@xarkes
Copy link
Contributor

xarkes commented Oct 18, 2018

@virteman Could you please explain why? If you are using Windows, you surely have Visual Studio installed, why would you use mingw or cygwin rather than the official VS tools?

@radare
Copy link
Collaborator

radare commented Oct 18, 2018 via email

@virteman
Copy link

virteman commented Oct 31, 2018

@xarkes cygwin can be used connect windows via ssh,then I can use linux terminal run r2 other than window's cmd.exe which is a ugly termal without some keybind as linux terminal.

@xarkes
Copy link
Contributor

xarkes commented Oct 31, 2018

There are many replacements for Windows cmd.exe, including WSL.
I mean that @radare argument makes more sense to me than what you are describing...

@radare
Copy link
Collaborator

radare commented Oct 31, 2018

Probably the biggest problem of all this is that e cant support all those targets with a single build. So window users will be confused again with 4 different zips to download and the problem is that they will behave wrongly depending on how you run them.. so its not just a development problem

@XVilka
Copy link
Contributor Author

XVilka commented Jan 9, 2019

@pelijah by the way, meson support for clang-cl is improving steadily and only some minor parts are now unsolved. See these bugs for keeping the track:

@XVilka
Copy link
Contributor Author

XVilka commented Mar 15, 2019

Resolved by bb67b54

@XVilka XVilka closed this as completed Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEEDBACK WANTED refactor Windows Microsoft Windows platform support issues
Projects
None yet
Development

No branches or pull requests

7 participants