Build fail on windows

[circleous]

I'm trying to build radare2 on windows using mingw-w64 (MSYS2).
Following radare gitbooks windows compilation instruction.

zip_close.c:645:28: error: ‘_O_BINARY’ undeclared (first use in this function)
     _setmode(_fileno(tfp), _O_BINARY );

Fails when trying to run make

[circleous]

HPCE/hpce-2015-cw2#3
Seems like this has same issue. After comment out the line, build is fine.

diff --git a/shlr/zip/zip/zip_close.c b/shlr/zip/zip/zip_close.c
index 42fa58c..d32f84a 100644
--- a/shlr/zip/zip/zip_close.c
+++ b/shlr/zip/zip/zip_close.c
@@ -642,7 +642,7 @@ _zip_create_temp_output(struct zip *za, FILE **outp)
       According to Pierre Joye, Windows in some environments per
       default creates text files, so force binary mode.
     */
-    _setmode(_fileno(tfp), _O_BINARY );
+    //_setmode(_fileno(tfp), _O_BINARY );
 #endif
 
     *outp = tfp;

[XVilka]

@circleous Why are you closed it?

[circleous]

The program runs fine so far. So, i thought for closing this.

[XVilka]

No, but the bug itself remains.

[radare]

commenting this fixes the build but breaks the usage. O_BINARY should be available on windows. mainly because its windows-only flag

[radare]

pushed a fix. pls confirm i dont have such env to test

[radare]

Ping?

…

On 19 Dec 2016, at 12:17, Anton Kochkov ***@***.***> wrote: No, but the bug itself remains. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[circleous]

warning: implicit declaration of function ‘_fileno’ This isnt only happen on _fileno but _snprintf, _read, ... winapi related. After digging out a bit, it needs -D_POSIX_SOURCE. After that, it triggers another error meanwhile the first problem is solved. Until now, i havent found any other solution for this.
sys.c:419:4: error: unknown type name ‘fd_set’
ref: http://stackoverflow.com/questions/15749184/fileno-not-available https://cygwin.com/ml/cygwin-apps/2013-04/msg00413.html

-fPIC is ignored in windows. This will trigger warning: -fPIC ignored for target (all code is position independent). Weird thing is that mk/platform.mk isnt filtering msys. Somewhat related #40 Since its intended so i leave it as is.

[radare]

Maybe the instructions are wrong? i just do sys/mingw32.sh and it builds fine on osx and linux

[circleous]

Oddly enough, build runs fine on cygwin x86 windows. So, i'm guessing warning: implicit declaration of function ‘_fileno and error on _read, _snprintf, etc.. somewhat related to my hacky current build system, not to mention some cflags added along the way. I'll try doing it from vanilla.

[XVilka]

Well, Cygwin 32/64, Mingw32 on Windows and Mingw32 on *nix, Mingw-w64, MSYS2, etc - everything is different and use different architectures. @circleous Can you please provide a full build log?

[radare]

I dont see the point on providing support for over9000 reimplementations of the same crappy abstractions of unix on top of windows when native windows builds work fine

…

On 20 Dec 2016, at 10:37, Anton Kochkov ***@***.***> wrote: Well, Cygwin 32/64, Mingw32 on Windows and Mingw32 on *nix, Mingw-w64, MSYS2, etc - everything is different and use different architectures. @circleous Can you please provide a full build log? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[XVilka]

well, Mingw32 is not very 'native' one, unlike Mingw-w64. Cygwin provides unix-like experience of radare2 on windows - true colors, piping with unix utils, etc. Mingw32 can be easily integrated with Visual Studio and so on. It's different target auditory.

[XVilka]

I can't reproduce it on my environment. @circleous are you?

[circleous]

Sorry for the wait. http://sprunge.us/ihHC
EDIT: This is tested on Windows 10 64 bit with Mingw-w64.

[radare]

For reference

…

On 23 Dec 2016, at 10:55, Kyra Sierra ***@***.***> wrote: Sorry for the wait. http://sprunge.us/ihHC — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[radare]

_fileno should be defined in stdio.h . see https://msdn.microsoft.com/en-us/library/zs6wbdhx.aspx

[radare]

So, as long as the fopen is done with the 'b' bit. this thing is totally unnecessary, i have just commented out. pls confirm its fixed

[circleous]

Yep, build is fine now.

[Maijin]

Then close