Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Ascii Art Graphs #2091

Closed
7 of 9 tasks
radare opened this issue Feb 14, 2015 · 4 comments
Closed
7 of 9 tasks

Color Ascii Art Graphs #2091

radare opened this issue Feb 14, 2015 · 4 comments

Comments

@radare
Copy link
Collaborator

radare commented Feb 14, 2015

Now the lines are colorized but there are still some things to be done to support full color on graphs, this issue aims to track all the related TODOs:

  • Colourize nodes: user defined
  • Colourize nodes that has been traced (like in the webui)
  • Permit colour disassembly (ANSI strings broke rconscanvas)
  • Fix the layout (avoid overlapped nodes)
  • Make lines smarter to avoid be over the nodes
  • Make colours configurable using the RCons palette (ec ..)
  • Bring back the old lines style (configurable)
  • Add support for utf-8 Feature-request: utf8 for VV-graphs #1675 (likely in canvas_line.c)
  • Optimize sort_attrs() and attr_at()
@r0nk
Copy link
Contributor

r0nk commented Feb 14, 2015

Many will undoubtfully notice that the colors are quite slow, this is due to the terribad algorithms I used to search and sort. If anyone is interested in making them faster, the offending functions are attr_at() and sort_attrs() in libr/cons/canvas.c, those two functions account for 90% of time spent when rendering.

@radare
Copy link
Collaborator Author

radare commented Nov 20, 2015

isnt this already done?

@Maijin
Copy link
Contributor

Maijin commented Nov 20, 2015

@radare Not yet :D

@radare radare modified the milestones: 1.1.0, 1.0.0 Oct 27, 2016
@radare radare modified the milestones: 1.2.0, 1.1.0 Nov 24, 2016
@radare radare modified the milestones: 1.3.0, 1.2.0 Jan 13, 2017
@radare radare modified the milestones: 1.4.0, 1.3.0 Feb 28, 2017
@Maijin Maijin closed this as completed Mar 9, 2017
@Maijin
Copy link
Contributor

Maijin commented Mar 15, 2017

(See META)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants