Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature] Add Util function to merge classes and merge all files to use the util #613

Closed
kotAPI opened this issue Dec 8, 2024 · 1 comment · Fixed by #630
Closed
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kotAPI
Copy link
Collaborator

kotAPI commented Dec 8, 2024

🚀 Feature Request


Feature Description

We currently apply classes to our components this way

className = `${rootClassName} ${className}`

Where we end up with empty spaces in class strings when a value isn't available.

<div class="rootclass "></div>

sometimes there's also a risk of className being undefined
which causes our classes to look like this

<div class="rootclass undefined"></div>

Using tools like clsx or any other utils can help with this

https://www.npmjs.com/package/clsx

This will also require us to refactor most of our components

@kotAPI kotAPI added enhancement New feature or request good first issue Good for newcomers labels Dec 8, 2024
@kotAPI
Copy link
Collaborator Author

kotAPI commented Dec 10, 2024

This is currently in works and championed by @GoldGroove06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant