-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Toggle/ToggleGroup components should be fully controlled #581
Comments
@kotAPI I would like to take care of this one. Could you assign it to me? UPD. I did a bit of research, lots of questions are coming up. I think we should define component behavior and props at first and then proceed with this issue. I started refactoring the code, but the APIs between components are not even similar. We are passing property X and Y to the component, when it expects property Z. I will raise a discussion in the dev channel a bit later and I will propose a solution |
Sure! Let's discuss and decide what to pick next! |
Hey @krau5, noting your inputs here for reference so we don't miss it in the threads, we'll have a detailed discussion on this and decide how to proceed, will update the issue with our decisions and directions so we leave a trail
|
Description
The Toggle and ToggleGroup components should be fully controlled, currently it is managed by having internal state
Ref-
#576 (comment)
The text was updated successfully, but these errors were encountered: