Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break Down App Restructure #229

Open
thebeanogamer opened this issue Jan 30, 2022 · 2 comments
Open

Break Down App Restructure #229

thebeanogamer opened this issue Jan 30, 2022 · 2 comments

Comments

@thebeanogamer
Copy link
Member

#119 is probably never getting merged. We need to make a list of all the changes within it so we can break them out and save what we can.

@0xAda
Copy link
Contributor

0xAda commented Jan 30, 2022

  • Refactor CI
  • New makefile targets
  • Fix makefile in ci (Let CI actually fail #212)
  • change guinicorn workers to 1 (already in master)
  • Add mypy
  • Add ignore:Using or importing the ABCs.*:DeprecationWarning to [tool.pytest.ini_options]
  • Add "/migrations/.py" to coverage exclude
  • Add flakehell
  • Add docstrings
  • Merge member and team apps
  • get_user_model() -> Member
  • Convert .id to .pk
  • Merge scorerecalculator into team app
  • Separate out authentication tests
  • Move RPN parser into challenge/logic/init.py
  • Delete half the migrations
  • Merge admin app into backend
  • Merge announcements app into backend
  • Merge experiments app into backend
  • Merge plugins app into backend
  • Merge ractf app into backend
  • Replace log level "DEBUG" with os.getenv("DJANGO_LOG_LEVEL", "DEBUG") (Pick smaller changes from app restructure: Logging configuration and docstrings for Andromeda #253)
  • Maybe add tests for permissions
  • Add tests for PrintableNameValidator
  • Add tests for experiments

@jerbob
Copy link
Member

jerbob commented Jan 30, 2022

#119 is probably never getting merged. We need to make a list of all the changes within it so we can break them out and save what we can.

My two cents: Considering I was assigned to fix up app-restructure before our meeting next week, I think we should hold off on carrying this out until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants