Controversial Language Change Suggestion #181
Conversation
|
@renee-travisci Thank you so much! This PR made my day. 😍
Lemme get tests passing on master again, and double-check that the upgrade path is smooth w/ deprecation warnings. Then I'll merge & release. |
|
@ktheory I've got a branch with working master tests! was just about to PR :) |
…l safelist/blocklist language add deprication warnings fix the method signatures
renee-travisci
force-pushed
the
language_change_suggestion
branch
from
d8a7da1
to
e1a0c80
Compare
|
I cleaned up a few things in #183 and just released v5.0.0.beta1. @renee-travisci: mind giving that a whirl on TravisCI's app and letting me know if you have any trouble? |
|
@ktheory honest question for you. What do you think about the pr-author's commitment to removing "charged" and "controversial" language from our industry when they throw around gender slurs on twitter? The rest of this comment was deleted by @ktheory, 1:39pm July 5. |
|
@ktheory thank you so much! We deployed 0.5.0.beta1 to production today -- running smooth so far! |
|
This comment was deleted by @ktheory, 1:39pm July 5. |
|
Hi @quecas-de-don-isidro, The author’s commitment and what I think of it are irrelevant and off-topic. Per Rack::Attack’s Code of Conduct:
Please refrain from personal attacks. I’m deleting the parts of your comments that I judge to be a personal attack and/or off-topic. |
Hello!
At Travis CI we've decided to change our usage of Whitelist/Blacklist to the less racially charged language of Safelist/Blocklist. We are using rack-attack and would love to use an updated version with our language choices if you are open to this change. I'm not sure how you would like to change the versioning of this so I didn't add any changes there. I know this would require users to update all of their whitelist/blacklist method calls to the new verbiage, which might annoy a number of end users. However, we did this with a simple find and replace (and method aliases until this change is welcomed). I added the depreciation warnings for the old method names to help users, however if anyone is relying on the rack.attack.match_type I changed it to safelist/blocklist (wasn't sure how to deprecate that nicely).
Thanks!
**Renée