Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code linter, CI tool and fix code warnings #25

Closed
will-molloy opened this issue Aug 13, 2019 · 3 comments
Closed

Add code linter, CI tool and fix code warnings #25

will-molloy opened this issue Aug 13, 2019 · 3 comments
Assignees
@rabidgremlin

Comments

@will-molloy
Copy link
Contributor

  • Add code linter (checkstyle + spotless) to apply consistent code formatting (for Java)
  • Fix code warnings by running code analysis tool (e.g. IntelliJ)
  • EXTRA: setup CI tool (e.g. travis/circle/github actions) to run build against PRs
@will-molloy will-molloy changed the title Add code linter and fix code warnings Add code linter, CI tool and fix code warnings Aug 13, 2019
@will-molloy
Copy link
Contributor Author

should wait for all PRs to be merged before starting this

@rabidgremlin rabidgremlin self-assigned this Oct 17, 2019
@rabidgremlin
Copy link
Owner

Have added this to v6 branch.

@will-molloy
Copy link
Contributor Author

#31 resolved this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rabidgremlin rabidgremlin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rabidgremlin @will-molloy