-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get ci pipelines functional, and switch to ruff linter/formatter #264
base: main
Are you sure you want to change the base?
Conversation
modified: requirements-ci.txt modified: .github/workflows/ci.yml
Why autopep8 over black? Is there actually a tangible improvement here? |
main things id say are, black isnt compatible with pep8 or flake8. it also formats quotes to double quotes and it removes trailing commas. secondly (kinda unrelated) me and tig are thinking abt precommit formatting. currently the repo is more autopep8 compliant than it is black. also if we are using flake8 for linting, precommit formatting with black might cause issues there |
Yeah fair enough I guess. Sounds good |
While we're in the area, it might be a good time to version lock the CI dependencies. Reproducible builds are good |
so just for comment here i undid the decision on black vs autopep8 after bit more digging the linters can be made to play nice with black, i forgot how much easier black formated code is to read |
Initial Checklist
Details
Does this resolve an issue?
Resolves #
Changes
Features / Fixes
Breaking Changes
Additional
Any further notes or comments you want to make.
im cool so i dont need to fill out the form