Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add NewClientFromReq method to allow streaming any kind of requests #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add NewClientFromReq method to allow streaming any kind of requests #164

wants to merge 1 commit into from

Conversation

radiantspace
Copy link

@radiantspace radiantspace commented Jun 3, 2023 •
edited
Loading

Allows making sse clients from any kind of requests, not just GET.

I needed that for streaming responses from OpenAI like this:

req, err := http.NewRequestWithContext(ctx, http.MethodPost, "https://api.openai.com/v1/chat/completions", bytes.NewBuffer(body))
if err != nil {
    return nil, err
}
req.Header.Set("Content-Type", "application/json")
req.Header.Set("Authorization", "Bearer "+a.authToken)

client := sse.NewClientFromReq(req)

...

Closes #153

@radiantspace
add NewClientFromReq method
2a32e59 
Allows making sse clients from any kind of requests, not just GET
@radiantspace radiantspace mentioned this pull request Jun 3, 2023
Open
wuhan005
wuhan005 suggested changes Aug 28, 2024
View reviewed changes
client.go
Comment on lines +309 to +310
if c.Request != nil {
} else {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if c.Request != nil {
} else {
if c.Request == nil {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuhan005 wuhan005 wuhan005 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Support non-GET method and request body in the sse client
2 participants
@radiantspace @wuhan005