Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning bigdecimal will no longer be part of Ruby 3.4.0 #107

Open
fukayatsu opened this issue Jul 22, 2024 · 3 comments
Open

Warning bigdecimal will no longer be part of Ruby 3.4.0 #107

fukayatsu opened this issue Jul 22, 2024 · 3 comments

Comments

@fukayatsu
Copy link

$ ruby -v
ruby 3.3.4 (2024-07-09 revision be1089c8ec) +YJIT [x86_64-linux]
/app/vendor/bundle/ruby/3.3.0/gems/r18n-core-5.0.1/lib/r18n-core/locale.rb:21: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of r18n-core-5.0.1 to add bigdecimal into its gemspec.
@fukayatsu fukayatsu changed the title Warnings bigdecimal will no longer be part of Ruby 3.4.0 Warning bigdecimal will no longer be part of Ruby 3.4.0 Jul 22, 2024
@simonneutert
Copy link

I would volunteer if needed, just let me know 🙋‍♂️

@AlexWayfer
Copy link
Contributor

How can I reproduce it? With bundle exec rspec and Ruby 3.3.5 I see no warnings about bigdecimal.

@simonneutert
Copy link

Provoke the warning in a mini example

Hope this helps 🤞

You need rackup to run the tiny roda based example.

gem install rackup

Then create a new directory and put the following file named config.ru in it. It is the example from roda's landing page, with the bundler bits you need to actually run.

# content of config.ru
require 'bundler/inline'

gemfile do
  source 'https://rubygems.org'
  gem "roda-i18n", "~> 0.6.0"
  gem "roda", "~> 3.84"
end

# cat config.ru
require "roda"

class App < Roda
  plugin :i18n

  route do |r|
    # GET / request
    r.root do
      r.redirect "/hello"
    end

    # /hello branch
    r.on "hello" do
      # Set variable for all routes in /hello branch
      @greeting = 'Hello'

      # GET /hello/world request
      r.get "world" do
        "#{@greeting} world!"
      end

      # /hello request
      r.is do
        # GET /hello request
        r.get do
          "#{@greeting}!"
        end

        # POST /hello request
        r.post do
          puts "Someone said #{@greeting}!"
          r.redirect
        end
      end
    end
  end
end

run App.freeze.app

run this app / config.ru file:

$ rackup

Screenshot

Screenshot 📸 image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants