-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fetch stable version #328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from the use of 'helpers'. Its highly subjective, but my view is that using 'helpers' does nothing for discoverability of code and therefore fails in terms of devex for the crate consumer. Modules can be descriptive and expressive.
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #328 +/- ##
==========================================
+ Coverage 70.33% 70.35% +0.02%
==========================================
Files 53 54 +1
Lines 9098 9105 +7
Branches 9098 9105 +7
==========================================
+ Hits 6399 6406 +7
Misses 1718 1718
Partials 981 981
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't point out anything. Nice one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
This PR addresses the sorting issue identified in: #325 where versioned tags were prioritized over
stable2409
in thepop up parachain
process.Changes