-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dry-run
flag to estimate gas
#203
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #203 +/- ##
==========================================
+ Coverage 68.55% 69.86% +1.30%
==========================================
Files 44 44
Lines 6374 6558 +184
Branches 6374 6558 +184
==========================================
+ Hits 4370 4582 +212
+ Misses 1337 1251 -86
- Partials 667 725 +58
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integration tests are required to test the call and up contracts, but is our of scope of this PR.
Can an issue be created for this.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
For
pop up contract
andpop call contract
adds a new flag--dry-run
to perform a dry-run via RPC to estimate the gas usage without submitting a transaction.Closes #134
This PR also corrects some inaccurate error messages and refactors these errors to use the
thiserror
crate in thepop_contracts
module. This refactor continues the work initiated in the previous PR: #111Integration tests are required to test the
call
andup
contracts, but is our of scope of this PR.