-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Quarto articles #2015
Closed
Closed
Support Quarto articles #2015
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
79a2ccc
Lint to test
olivroy c7e7243
Support quarto vignettes and articles
olivroy 1fb0a63
Add templates
olivroy 90f521d
Merge branch 'main' into quarto-articles
olivroy 2c7adea
Apply suggestions from code review
olivroy 3dd240e
Update vignette and article template
olivroy 08b0a84
Merge branch 'main' into quarto-articles
jennybc 3b9670c
Merge branch 'main' into olivroy-quarto-articles
jennybc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
--- | ||
title: "{{{ vignette_title }}}" | ||
format: html | ||
olivroy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
knitr: | ||
opts_chunk: | ||
collapse: true | ||
comment: "#>" | ||
--- | ||
|
||
```{r setup} | ||
library({{Package}}) | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
--- | ||
title: "{{{ vignette_title }}}" | ||
format: html | ||
knitr: | ||
opts_chunk: | ||
collapse: true | ||
comment: "#>" | ||
vignette: > | ||
%\VignetteIndexEntry{{{ braced_vignette_title }}} | ||
%\VignetteEngine{quarto::html} | ||
%\VignetteEncoding{UTF-8} | ||
--- | ||
|
||
```{r} | ||
#| label: setup | ||
library({{Package}}) | ||
``` | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type
is a little over-generic and could collide with another param. Let's use the more-specificbuilder
(to match "VignetteBuilder"). If you go with this change, it needs to be changed throughout.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed that
type
may not be ideal. If we were to go with builder, the arguments should be updated to "knitr" instead of "rmarkdown"?Maybe
ext = c("qmd", "rmd")
would work too.Maybe there should be an option
options(usethis.vignette = "quarto")
to avoid specifying it everytime?I can imagine myself deciding to stick with a single type, and not have to specify it everytime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like
ext
, and an option would be great!