Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename use_github_action_check_full() #1490

Closed
hadley opened this issue Sep 19, 2021 · 3 comments
Closed

Rename use_github_action_check_full() #1490

hadley opened this issue Sep 19, 2021 · 3 comments
Labels
git git, GitHub, and CI in general

Comments

@hadley
Copy link
Member

hadley commented Sep 19, 2021

Maybe to use_github_action_check_tidy()? Want to more clearly imply that overkill for most folks.

cc @jimhester

@jimhester
Copy link
Member

I think calling it tidy might actually cause more people to use it, not less.

@hadley
Copy link
Member Author

hadley commented Sep 20, 2021

But the convention (in usethis at least), is the "tidy" stuff is for internal use. Maybe we should just drop the function altogether and rely use_tidy_github_actions() for our own use?

@jimhester
Copy link
Member

I think dropping the function would be fine.

@jennybc jennybc added the git git, GitHub, and CI in general label Sep 28, 2021
@jennybc jennybc added this to the v2.1.0 milestone Sep 28, 2021
@jennybc jennybc closed this as completed in 6448f38 Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git git, GitHub, and CI in general
Projects
None yet
Development

No branches or pull requests

3 participants