Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename label_dollar to label_currency #344

Closed
pwseo opened this issue Apr 14, 2022 · 3 comments
Closed

Rename label_dollar to label_currency #344

pwseo opened this issue Apr 14, 2022 · 3 comments

Comments

@pwseo
Copy link

pwseo commented Apr 14, 2022

Shouldn't label_dollar be renamed label_currency? I know it is functionally the same, but such a name would instantly tell the programmer that multiple currencies are probably supported, prompting one to read the documentation on how to specify them, instead of searching (for example) for a label_euro.

@clauswilke
Copy link
Collaborator

I fully agree with this comment. I taught this recently in the classroom and it was clear that the students were very confused when I was using a function label_dollar to create all sorts of different labels.

@olivroy
Copy link

olivroy commented Nov 1, 2023

I think this is great. Maybe it would be great that label_currency() to be locale dependant (like label_date() that creates the scales in your system's language by default

@thomasp85
Copy link
Member

@olivroy I don't think that is a good idea as it is much more normal to work with data in a currency that is not your own compared to using a date format different from your locale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants