You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we are relying on pkg-config and the existence of jpeg.pc, can we remove the additional -ljpeg?
Alternatively, should fa87a16 be reverted? The argument for that is that older versions of libjpeg did not install a jpeg.pc for pkg-config to use.
I don't particularly mind which of the two solutions we land on.
The text was updated successfully, but these errors were encountered:
georgestagg
changed the title
When linking with library flags generated by pkg-confg, the -ljpeg flag is duplicated
When linking with library flags generated by pkg-config, the -ljpeg flag is duplicated
Dec 13, 2023
As I am listed as the official author of this particular script, I'll use my executive powers here :)
I checked a few old linux distros and all of them install the libjpeg-turbo drop-in replacement instead of the original libjpeg implementation when you install libjpeg-dev or libjpeg-devel . The libjpeg-turbo library has always included a proper libjpeg.pc, so therefore requiring this is probably fine these days (otherwise we would have heard about it by now).
See discussion in #152 for more context. The short version is that duplicated link flags fails when building for webR/Wasm with Emscripten.
In the package's
configure
script,pkg-config
is used to findlibjpeg
,ragg/configure
Line 8 in 792c1e1
but later, the
-ljpeg
flag is also manually appended,ragg/configure
Lines 37 to 39 in 792c1e1
If we are relying on
pkg-config
and the existence ofjpeg.pc
, can we remove the additional-ljpeg
?Alternatively, should fa87a16 be reverted? The argument for that is that older versions of libjpeg did not install a
jpeg.pc
forpkg-config
to use.I don't particularly mind which of the two solutions we land on.
The text was updated successfully, but these errors were encountered: