From f38061c59af2265df624c9e10aae415c3b45af31 Mon Sep 17 00:00:00 2001 From: Thomas Lin Pedersen Date: Tue, 10 Oct 2023 09:23:59 +0200 Subject: [PATCH] revdep and doc --- DESCRIPTION | 2 +- NEWS.md | 1 + cran-comments.md | 23 +++++++++++++- man/ragg-package.Rd | 4 +-- revdep/README.md | 12 ++++++++ revdep/cran.md | 17 +++++++++-- revdep/failures.md | 74 ++++++++++++++++++++++++++++++++++++++++++++- revdep/problems.md | 42 ++++++++++++++++++++++++- 8 files changed, 166 insertions(+), 9 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 49ff43f4..fb91e77d 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -37,6 +37,6 @@ LinkingTo: Config/Needs/website: ggplot2, devoid, magick, bench, tidyr, ggridges, hexbin, sessioninfo, pkgdown, tidyverse/tidytemplate Encoding: UTF-8 -RoxygenNote: 7.2.1 +RoxygenNote: 7.2.3 SystemRequirements: freetype2, libpng, libtiff, libjpeg Config/testthat/edition: 3 diff --git a/NEWS.md b/NEWS.md index 050c6d77..b3dd82fa 100644 --- a/NEWS.md +++ b/NEWS.md @@ -2,6 +2,7 @@ * Fix symbol rendering bug on windows (#132) * Add support for `dev.capabilities()` (#105) +* Prepare for Arm Windows # ragg 1.2.5 diff --git a/cran-comments.md b/cran-comments.md index ead02a9c..aeb06291 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1 +1,22 @@ -Moving `sprintf()` to `snprintf()` at request of cran along with a few bug fixes +A few bug fixes as well as prep for Arm Windows. The one revdep failure seems +to be related as the package is not using any ragg functionality. + +## revdepcheck results + +We checked 37 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. + + * We saw 1 new problems + * We failed to check 1 packages + +Issues with CRAN packages are summarised below. + +### New problems +(This reports the first line of each new failure) + +* WhatsR + checking tests ... ERROR + +### Failed to check + +* ursa (NA) + diff --git a/man/ragg-package.Rd b/man/ragg-package.Rd index 25fe4a13..952c49c3 100644 --- a/man/ragg-package.Rd +++ b/man/ragg-package.Rd @@ -20,7 +20,7 @@ Useful links: } \author{ -\strong{Maintainer}: Thomas Lin Pedersen \email{thomas.pedersen@rstudio.com} (\href{https://orcid.org/0000-0002-5147-4711}{ORCID}) +\strong{Maintainer}: Thomas Lin Pedersen \email{thomas.pedersen@posit.co} (\href{https://orcid.org/0000-0002-5147-4711}{ORCID}) Authors: \itemize{ @@ -32,7 +32,7 @@ Other contributors: \item Tony Juricic \email{tonygeek@yahoo.com} (Contributor to AGG) [contributor, copyright holder] \item Milan Marusinec \email{milan@marusinec.sk} (Contributor to AGG) [contributor, copyright holder] \item Spencer Garrett (Contributor to AGG) [contributor] - \item RStudio [copyright holder, funder] + \item Posit, PBC [copyright holder, funder] } } diff --git a/revdep/README.md b/revdep/README.md index 52e12c71..0b19921c 100644 --- a/revdep/README.md +++ b/revdep/README.md @@ -1,2 +1,14 @@ # Revdeps +## Failed to check (1) + +|package |version |error |warning |note | +|:-------|:-------|:-----|:-------|:----| +|ursa |3.10.1 |1 | |1 | + +## New problems (1) + +|package |version |error |warning |note | +|:----------------------------|:-------|:------|:-------|:----| +|[WhatsR](problems.md#whatsr) |1.0.1 |__+1__ | | | + diff --git a/revdep/cran.md b/revdep/cran.md index fbbeef90..0b753700 100644 --- a/revdep/cran.md +++ b/revdep/cran.md @@ -1,7 +1,18 @@ ## revdepcheck results -We checked 25 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. +We checked 37 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. - * We saw 0 new problems - * We failed to check 0 packages + * We saw 1 new problems + * We failed to check 1 packages +Issues with CRAN packages are summarised below. + +### New problems +(This reports the first line of each new failure) + +* WhatsR + checking tests ... ERROR + +### Failed to check + +* ursa (NA) diff --git a/revdep/failures.md b/revdep/failures.md index 9a207363..c9eb0ac3 100644 --- a/revdep/failures.md +++ b/revdep/failures.md @@ -1 +1,73 @@ -*Wow, no problems at all. :)* \ No newline at end of file +# ursa + +
+ +* Version: 3.10.1 +* GitHub: https://github.com/nplatonov/ursa +* Source code: https://github.com/cran/ursa +* Date/Publication: 2023-10-07 18:20:02 UTC +* Number of recursive dependencies: 122 + +Run `cloud_details(, "ursa")` for more info + +
+ +## In both + +* checking whether package ‘ursa’ can be installed ... ERROR + ``` + Installation failed. + See ‘/tmp/workdir/ursa/new/ursa.Rcheck/00install.out’ for details. + ``` + +* checking package dependencies ... NOTE + ``` + Package suggested but not available for checking: ‘gdalraster’ + ``` + +## Installation + +### Devel + +``` +* installing *source* package ‘ursa’ ... +** package ‘ursa’ successfully unpacked and MD5 sums checked +** using staged installation +** libs +gcc -I"/opt/R/4.1.1/lib/R/include" -DNDEBUG -I/usr/local/include -fpic -g -O2 -c init.c -o init.o +gcc -I"/opt/R/4.1.1/lib/R/include" -DNDEBUG -I/usr/local/include -fpic -g -O2 -c ursa.c -o ursa.o +gcc -shared -L/opt/R/4.1.1/lib/R/lib -L/usr/local/lib -o ursa.so init.o ursa.o -L/opt/R/4.1.1/lib/R/lib -lR +installing to /tmp/workdir/ursa/new/ursa.Rcheck/00LOCK-ursa/00new/ursa/libs +** R +Error in parse(outFile) : + /tmp/workdir/ursa/new/ursa.Rcheck/00_pkg_src/ursa/R/package_vapour.R:125:94: unexpected input +124: else +125: ursa_value(a) <- vapour::gdal_raster_data(fname,bands=seq(a)) |> do.call(cbind,args=_ + ^ +ERROR: unable to collate and parse R files for package ‘ursa’ +* removing ‘/tmp/workdir/ursa/new/ursa.Rcheck/ursa’ + + +``` +### CRAN + +``` +* installing *source* package ‘ursa’ ... +** package ‘ursa’ successfully unpacked and MD5 sums checked +** using staged installation +** libs +gcc -I"/opt/R/4.1.1/lib/R/include" -DNDEBUG -I/usr/local/include -fpic -g -O2 -c init.c -o init.o +gcc -I"/opt/R/4.1.1/lib/R/include" -DNDEBUG -I/usr/local/include -fpic -g -O2 -c ursa.c -o ursa.o +gcc -shared -L/opt/R/4.1.1/lib/R/lib -L/usr/local/lib -o ursa.so init.o ursa.o -L/opt/R/4.1.1/lib/R/lib -lR +installing to /tmp/workdir/ursa/old/ursa.Rcheck/00LOCK-ursa/00new/ursa/libs +** R +Error in parse(outFile) : + /tmp/workdir/ursa/old/ursa.Rcheck/00_pkg_src/ursa/R/package_vapour.R:125:94: unexpected input +124: else +125: ursa_value(a) <- vapour::gdal_raster_data(fname,bands=seq(a)) |> do.call(cbind,args=_ + ^ +ERROR: unable to collate and parse R files for package ‘ursa’ +* removing ‘/tmp/workdir/ursa/old/ursa.Rcheck/ursa’ + + +``` diff --git a/revdep/problems.md b/revdep/problems.md index 9a207363..d1780896 100644 --- a/revdep/problems.md +++ b/revdep/problems.md @@ -1 +1,41 @@ -*Wow, no problems at all. :)* \ No newline at end of file +# WhatsR + +
+ +* Version: 1.0.1 +* GitHub: NA +* Source code: https://github.com/cran/WhatsR +* Date/Publication: 2023-06-01 22:50:14 UTC +* Number of recursive dependencies: 140 + +Run `cloud_details(, "WhatsR")` for more info + +
+ +## Newly broken + +* checking tests ... ERROR + ``` + Running ‘testthat.R’ + Running the tests in ‘tests/testthat.R’ failed. + Complete output: + > library(testthat) + > library(WhatsR) + The legacy packages maptools, rgdal, and rgeos, underpinning the sp package, + which was just loaded, were retired in October 2023. + Please refer to R-spatial evolution reports for details, especially + https://r-spatial.org/r/2023/05/15/evolution4.html. + It may be desirable to make the sf package available; + ... + 29: tryCatchOne(expr, names, parentenv, handlers[[1L]]) + 30: tryCatchList(expr, classes, parentenv, handlers) + 31: tryCatch(code, testthat_abort_reporter = function(cnd) { cat(conditionMessage(cnd), "\n") NULL}) + 32: with_reporter(reporters$multi, lapply(test_paths, test_one_file, env = env, desc = desc, error_call = error_call)) + 33: test_files_serial(test_dir = test_dir, test_package = test_package, test_paths = test_paths, load_helpers = load_helpers, reporter = reporter, env = env, stop_on_failure = stop_on_failure, stop_on_warning = stop_on_warning, desc = desc, load_package = load_package, error_call = error_call) + 34: test_files(test_dir = path, test_paths = test_paths, test_package = package, reporter = reporter, load_helpers = load_helpers, env = env, stop_on_failure = stop_on_failure, stop_on_warning = stop_on_warning, load_package = load_package, parallel = parallel) + 35: test_dir("testthat", package = package, reporter = reporter, ..., load_package = "installed") + 36: test_check("WhatsR") + An irrecoverable exception occurred. R is aborting now ... + Segmentation fault (core dumped) + ``` +