Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc section on debug compiler flags #303

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

mcol
Copy link
Contributor

@mcol mcol commented Nov 4, 2024

This fixes #301 as suggested in #302. See if the wording is clear enough, suggestions welcome!

Copy link
Member

@lionel- lionel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a small suggestion

R/load.R Outdated
Comment on lines 71 to 72
#' appended. If this is undesired (for example, if you would like to produce
#' an optimized build), you can opt out by setting the `pkg.build_extra_flags`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#' appended. If this is undesired (for example, if you would like to produce
#' an optimized build), you can opt out by setting the `pkg.build_extra_flags`
#' appended. If you would like to produce an optimized build instead),
#' you can opt out by setting the `pkg.build_extra_flags`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I didn't apply it directly for a mismatched bracket. :)

@lionel- lionel- merged commit d10172c into r-lib:main Nov 4, 2024
13 checks passed
@lionel-
Copy link
Member

lionel- commented Nov 4, 2024

Thank you for this!

@mcol mcol deleted the issue_301 branch November 4, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a debug argument to load_all()
2 participants