Depend on pkgbuild unconditionally (#250)

Closes #249
r-lib · Jul 5, 2023 · 58567be · 58567be
1 parent 371b849
commit 58567be
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -25,6 +25,7 @@ Imports:
     fs,
     glue,
     methods,
+    pkgbuild,
     rlang (>= 1.1.1),
     rprojroot,
     utils,
@@ -35,7 +36,6 @@ Suggests:
     mathjaxr,
     mockr,
     pak,
-    pkgbuild,
     Rcpp,
     remotes,
     rstudioapi,

diff --git a/NEWS.md b/NEWS.md
@@ -1,10 +1,13 @@
 # pkgload (development version)
 
-* `load_all()` no longer standardises version number in namespace metadata 
+* pkgload now depends unconditionally on pkgbuild (#249).
+
+* `load_all()` no longer standardises version number in namespace metadata
   (#231).
-  
+
 * New `pkg_version_raw()` to get raw package version as a string.
 
+
 # pkgload 1.3.2
 
 * Fixes for CRAN checks.

diff --git a/R/load.R b/R/load.R
@@ -149,11 +149,9 @@ load_all <- function(path = ".",
   }
 
   if (isTRUE(compile)) {
-    rlang::check_installed("pkgbuild", reason = "to compile packages with a `src/` directory.")
     pkgbuild::clean_dll(path)
     pkgbuild::compile_dll(path, quiet = quiet)
   } else if (identical(compile, NA)) {
-    rlang::check_installed("pkgbuild", reason = "to compile packages with a `src/` directory.")
     pkgbuild::compile_dll(path, quiet = quiet)
   } else if (identical(compile, FALSE)) {
     # don't compile