Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarto vignette titles are broken with quarto 1.6.x #2823

Open
banfai opened this issue Nov 25, 2024 · 2 comments
Open

Quarto vignette titles are broken with quarto 1.6.x #2823

banfai opened this issue Nov 25, 2024 · 2 comments
Labels

Comments

@banfai
Copy link
Contributor

banfai commented Nov 25, 2024

With the pre-release version of quarto the page title has a glitch, it's in a different div <header id="title-block-header" class="quarto-title-block">) instead of the previous <div class="page-header">. This causes the Source link to be placed above the title:

release version on gh-pages:
quarto-vignette-1 5 x

same version rendered with quarto 1.6.37:
quarto-vignette-1 6 37

The page-header div is still there with the logo and the source code link, but the title is missing: <h1></h1>

quarto::quarto_version()
#> [1] '1.6.37'

It remains the same with specifying

format:
  html:
    title-block-style: none
@banfai
Copy link
Contributor Author

banfai commented Nov 26, 2024

I believe it's caused by this:
quarto-dev/quarto-cli#10567
quarto-dev/quarto-cli#11224

@jayhesselberth
Copy link
Collaborator

jayhesselberth commented Nov 26, 2024

Quarto tests are also failing with the new release, this appears to be the same problem:

Failure (test-build-quarto-articles.R:59:3): auto-adjusts heading levels
xpath_text(html, "//h1") (`actual`) not equal to "title" (`expected`).

`actual`:   "" "title"
`expected`:    "title"

Failure (test-build-quarto-articles.R:104:3): quarto headings get anchors
xpath_attr(headings, "./a", "href") (`actual`) not equal to c("#heading-1", "#heading-2") (`expected`).

`actual`:   "#heading-1"             
`expected`: "#heading-1" "#heading-2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants