Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use inherits() rather than string-comparison #246

Closed
ijlyttle opened this issue Dec 31, 2023 · 0 comments · Fixed by #249
Closed

refactor: use inherits() rather than string-comparison #246

ijlyttle opened this issue Dec 31, 2023 · 0 comments · Fixed by #249

Comments

@ijlyttle
Copy link
Member

Dusting this off after far too long; got this on R CMD Check:

  Found if() conditions comparing class() to string:
  File ‘boxr/R/boxr__internal_dir_comparison.R’: if (class(absent) != "data.frame") ...
  File ‘boxr/R/boxr__internal_get.R’: if (class(obj) == "boxr_file_reference") ...
  File ‘boxr/R/boxr__internal_get.R’: if (class(obj) == "boxr_object_list") ...
  Use inherits() (or maybe is()) instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use inherits() r-box/boxr
1 participant
@ijlyttle