Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up temp files #183

Closed
ijlyttle opened this issue Sep 20, 2020 · 0 comments · Fixed by #258
Closed

clean up temp files #183

ijlyttle opened this issue Sep 20, 2020 · 0 comments · Fixed by #258

Comments

@ijlyttle
Copy link
Member

As I understand, one of the CRAN rules is that a function that creates a temp file shall delete that temp file, essentially "leave no footprints". As well, as I understand, they check this for new packages, but not for updates. Even so, I think it is a sound idea.

As I make my way through #159, I am adding on.exit(fs::file_delete(temp_file)) to whatever I come across, but I think we should make a larger effort of this.

Making things more interesting is that there will soon be a new release of {withr} with a set of tools that the Tidyverse team will use to take care of this (r-lib/usethis#1217) - maybe we could do the same, but not immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant