Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat exceptions raised outside of notebook cells as errors #33

Closed
hodgestar opened this issue Aug 10, 2022 · 2 comments · Fixed by #39
Closed

Treat exceptions raised outside of notebook cells as errors #33

hodgestar opened this issue Aug 10, 2022 · 2 comments · Fixed by #39

Comments

@hodgestar
Copy link
Contributor

I opened a feature request on the nbmake repository to handle this case treebeardtech/nbmake#77.
@hodgestar
Copy link
Contributor Author

This has been fixed in nbmake 1.3.4 -- treebeardtech/nbmake#77. We should try it out and then close this once we've confirmed it works for us.

@christian512 christian512 mentioned this issue Aug 19, 2022
Merged
@christian512
Copy link
Collaborator

I can confirm that the error which we had before in one of the notebooks is now detected correctly by nbmake. I upgraded the version of nbmake in #39 and close this issue accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade nbmake version christian512/qutip-tutorials
2 participants
@hodgestar @christian512