This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
Bug: listening first verse does not continue to the next. #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to: http://staging.quran.com:32854 |
AhmedShab
commented
Apr 30, 2017
src/config.js
Outdated
| @@ -19,7 +19,7 @@ const config = { | |||
| sentryServer: process.env.SENTRY_KEY_SERVER, | |||
| facebookAppId: process.env.FACEBOOK_APP_ID, | |||
| // Supported locales | |||
| locales: { en: 'English', ar: 'العربية', ur: 'اردو', id: 'Bahasa Indonesia', tr: 'Türkçe', fr: 'Français' }, | |||
| locales: { en: 'English', ar: 'العربية', ur: 'اردو', id: 'Bahasa Indonesia', tr: 'Türkçe', fr: 'Langue du Site' }, | |||
There was a problem hiding this comment.
Not sure why this changed
There was a problem hiding this comment.
hmm, try;
git checkout src/config.js
or
git checkout master -- src/config.js
AhmedShab
commented
Apr 30, 2017
| // LOAD_FAIL | ||
| } from 'redux/constants/audioplayer.js'; | ||
| } from 'redux/constants/audioplayer.js'; | ||
|
|
|
Deployed to: http://staging.quran.com:32855 |
added 2 commits
April 30, 2017 20:53
AhmedShab
force-pushed
the
fix-listening-first-verse
branch
from
8760a18
to
91be4aa
Compare
|
Deployed to: http://staging.quran.com:32856 |
|
Deployed to: http://staging.quran.com:32857 |
…into fix-listening-first-verse
|
Any feedback for this pull request? Thank you |
|
@AhmedShab sorry for being late. Is this the only big change? https://github.com/quran/quran.com-frontend/pull/771/files#diff-1a6763b6756935a86cbd6274219e82bcR36 |
|
@mmahalwy sorry for my late respond as well, yes that's it. We never set duration to one before. Sometimes it was getting funny values like What do you think? |
|
Deployed to: http://staging.quran.com:32782 |
…into fix-listening-first-verse
AhmedShab
force-pushed
the
fix-listening-first-verse
branch
from
976e5ea
to
c3d21e4
Compare
|
Deployed to: http://staging.quran.com:32783 |
thabti
approved these changes
May 14, 2017
|
@AhmedShab sorry for any delay approved. @mmahalwy all cool? |
|
Thank you @AhmedShab for your contribution. Sorry for any delays in getting this merged in. I have tested it and the bug has been resolved. <3 |
|
No worries 😄. Now I have a better idea about the code base, I will keep helping with this whenever I can. Most weekend I have more time, will do it during the week too when I have the chance 👍 |
naveed-ahmad
added a commit
that referenced
this pull request
May 17, 2017
* Fixed routes Merge master into production Merge master into production (#436) * Mobile landing page (#419) * Fix build issue with babel-preset-es2015 babel-preset-es2015 6.13.1 causes issues with babel-preset-es2015-webpack, so this freezes the dependency of babel-preset-es2105 to 6.9.0. * guide updated * Feature/refactor redux (#414) * refactoring the redux structure to something more standard. * ayahs actions/reducers * SURAHS actions/reducers * search action * options and fontface actions * lowercase the file names * rename actions/actionTypes * isLoaded is now a helper function, added audioplayer * fix * action unit tests * Babel fixes * extract problem * fix this time * Okay now. * Mobile page updates (#424) * Mobile page updates * smaller * fix * Fixes #411 - Repeat range bug (#425) * Fixes #400 Developer page (#426) * Upgrade express to the stable version (#433) Express 4.3.2, which we use, has a vulnerability. The stable version should not have this vulnerability (the version we are using is from 2014, whereas the stable one was just updated in June of this year). * https all the things (#434) * Bump node version (#431) * Remove svg fonts (#432) This patch removes svg fonts, since browsers are dropping support for svg fonts, and, furthermore, these fonts don't actually work at the moment. Fixes #429. Merge branch 'master' into production Quran v2.3.0 (#592) * Fixes #461 (#473) * improved aya/sura url param handling * improved code to ayah/surah url handler * used Route from react-router to handle reroute * Added tooltip prop for Ayah component in Search page (#474) * Create LICENSE.md (#477) * added Nafees font for Urdu and Punjabi translation * footer layout improved (#490) * Quick links layout improved. (#491) * footer layout improved * quick links layout improved * Update index.js * Adding margin to quick links section * User authentication and profile (#460) * wip * user stuff * Profile page! * Unneeded calls * PR feedback * go stateless * dup route * oops decorators * Add user bookmarks * Adding media and modal (#493) * Adding media and modal * squeeze a fix * Renav (#495) * surah page layout breakdown fixed * Fix node-http-proxy host in proxy request (#501) node-http-proxy was putting a host header with the current server name, which was thus causing nginx on the receiving end to send the request to the default handler (or the first one). This patch asks node-http-proxy to rewrite the host and port, and also to change the origin of the host header to onequran's url. * Env problems (#494) * Adding media and modal * Fix envs * Moving docker env closer * return dockerfile as is * fixes * give it a try * try again * desparate times * desparate times * host * sidebar * fix * tooltip fix * corrected elements nesting * edited * fixing tooltip bottom triangle glitch * moved getOffset function to utils folder * formatted code * wip on app install banner #427 * used fa icon for close btn * added event tracking for install and close banner * using default fonts for banner * removed one hiding console.log * fix unit tests * tooltip fix * corrected elements nesting * edited * fixing tooltip bottom triangle glitch * moved getOffset function to utils folder * formatted code * removed one hiding console.log * corrected QuickSurah assertion test * corrected quicksurah tests * experimental check * another exprerimental check * another workaround for tests * exporting tooltip code to file * editing. * another attempt * another attempt * removing eslint errors * removing eslint errors - final * removing eslint errors - final * fixed the banner icon and minor styling * do not always load bismillah (#515) * do not always load bismillah * while at it, lets not load images when we do not need them * Code splitting (#516) * Code splitting to work * working * added favicons, opensearch, and manifest files for chrome * removed web from related app * highlight currently playing ayah (#510) * added service worker and preconnect meta tags * don' show custom banner on chrome > 44 and safari > 6 * meh, when this was replaced * added prefer related apps * initial work on react-share * fix style * fix facebook share * add cursor pointer for the icons * fix surah still display Loading even in last of surah (#521) * switched hightlight color to green * added nightmode css and optimized svgs #201 * fixed night color for missing elements, added bare min component * added hightlight for readmore * changed night more UI * updated night mode UI * Added no script warning (#527) * added no script warning * fixed messaging * minor css changes * removed font size * fixed noscript break (#535) * fixed noscript break * fixed the link * loaders when navigating on client side * notes on autocomplete * Use new segments and surah info data (#542) * Use new segments and surah info data * delete alot of files * removed bootstrap scripts and descriptions * Local support (#523) * Work in progress for #245 * refactored local, local specific fonts, almost done with i18n :) * fixed search break and added other missing translation keys * added local switch * fixed the bug * fixed noscript break * added intl pollyfil * replaced double quote with single quote * fixing specs * formatting * more formatting * fixed noscript break * fixed the link * fixed specs using mound instead of shallow * added arabic local * PhantomJS don't support! fixed intl helper with vanilla js * added local for bookmark * Fixed sidebar (#554) * we needed bs dropdown man * fixed sidebar * New React + eslint (#543) * stylelint * autocomplete * make search work * more lints * fix audio * remove row component * move to deps * tests are not running * tests passing * fix travis tests * jquery * Add new normalizr (#565) * (#564) Fixes #562 Highlight ayah when playing * Fixes #557 Scrollbars bouncing (#563) * Add slack to readme (#570) * Fixes #547 Support continuing from last visited ayah (#559) * Fix last visited functionality - Read last visited surah/ayah from cookie and show resume option on main page if cookie exists - Refactor and cleanup previous last visited code to be more readable and match the new UI * Update lastVisit cookie ayah requests, switch cookie ayah field to ayahId for consistency * Delete last visit styles.scss * Change resume heading to continue and support urdu/arabic translations * Move vertical lines from class title into new class The existing .title class made it difficult for titles that are not a series of items to use the span tag as it would add unwanted vertical lines. The only user of this was QuickSurahs component. I moved the vertical lines into a new "items" class so that all other users which are not a series of items can use the title class without getting vertical lines in spans. Only last visit benefits from this at the moment since the main Home component doesn't have any spans inside the title and there are no other users of this scss file. * Add debug line back in lastvisit * Minor refactoring * Devise Token Auth for one quran (#571) * Devise Token Auth for one quran * pr comments * Highlight word in reading mode as well (#556) * highlight current word is readmode as well * added word by word play! buggy but working * fixed word position in reading modet * DRYed word render and added tooltip in reading mode * fixed trans language class * refactoring word rendering * refactored word rendering * removed duplicated code * removed debuging * adding auto scrolling in reading mode * Update docs (#567) * Update docs * Update CONTRIBUTING.md * Update README.md * Mention staging * Optimization of assets (#585) * quick optimization of assets * typo * #568 UI improvements (#583) * moved topoptions to navbar drawer * fix lint * fix tests * break eslint * fix eslint * fix test * verse dropdown max height * Global Nav * small bug * change again * placeholder for search * global nav edits and to merge so one pr * a ton of changes and i want to sleep now * fix test * remove unneeded * more delete * fix errors * fixes ##561 * console * delete that * minor style changes * pr comments * fixes audio * always close * Remove missing contents (#589) Merge branch 'master' into production Merge pull request #606 from quran/master Merge master into production Rename Bayyinah string Merge pull request #641 from quran/fix_bayyinah Rename Bayyinah string Fix/smart banner appid switch and close/open (#646) (#682) Release v3 (#740) * Webpack 2 (#597) * working for dev * production working * push for now * missing package * fix * Fixes staging and Fixes #593 (#612) * Fixes staging and Fixes #593 * fix dev tools * better urdu translation * Update server.prod.js (#616) * Share on every ayah + ayah level url (#618) * Added Indonesian Translation (#613) * Added Indonesian Translation * Edit config.js * Update id.js Adding and editing indonesian translation. * fixed local change link (#622) * fixed local change link * :/ * fixed lint err * another lint! * Error page space bug fixed (#628) * Copy-edit english locale Replaces some awkward wording with some less awkward wording. * Feature/back to home + css fix (#636) * Added back to home link in sidebar * Fixed CSS loading issue for the back to home link * Rename Bayyinah string * Fixes for repeat range bugs (#644) * Fix 'from' onChange * Fix available 'to' options * Fix available 'from' options * Added top margin to the index header logo (#643) * Fix/smart banner appid switch and close/open (#646) * tr.js - Turkish language locale file added (#660) * some translation improved (#662) * V3 API (#633) * changes * work homepage * fix surah * Fix linting * chapter for repeat dropdown * Fixed typo in urdu locale (#649) * Fixes #657 Recitations dropdown from API call (#664) * added turkish locale name in config (#661) added turkish locale name in config line:22 * Fixes #659 Double Click for Word Audio (#665) * Fixes #659 Double Click for Word Audio * replaced the clicks on word * fixed local keys (#668) * fixed rendering of pause, sajdah and rub( pause word) (#666) * fixed rendering of pause, sajdah and rub( pause word) * fixed lint errors * added surah name and bismillah icons (#667) * added surah name and bismillah icons * fixed lint * Surah page (#670) * fixed responsive issues for surah translated name * fixed verse badge * fixed media * last word in ayah ( ayah number ) don't have audio * fixed translations * .env should be in gitignore list! * fixed lint rules * make slack more prominent (#680) * make slack more prominent * Update README.md * Enhancement added - Now copy Ayah feature includes Surah and Ayah number (#647) * Enhancement added - Now copy Ayah feature includes Surah and Ayah number * Rebased :) * Stagin API Added * Fixes #656 Translation dropdown (#671) * translation type * add content type * Fix autoscroll jankiness (#683) * Switch verse PK back to verseKey - fixes continous playback, etc * Fix lagging autoscroll, bad scroll alignment * Forgot one `offset` term. * Text based fonts (#672) * added word rendering comparision * regenerated surah name icon fonts using private unicode area * render text fonts for supported browsers only * moved user agent to options tree * fixed lint breaks * fixed floating of ayah number word * added empty space after 'word' word :) * French localization (#684) * French localization Add French localization, courtesy of brother Nadim Sohail, may Allah reward him greatly! * (WIP) Integration work with quran-components (#679) * add the surahTitle and jumbotron components * add vscode to gitignore * remove vscode * use lib folder of the surahTitle component * fix title in position * use quran-components Loader * use loader * remove functional tests (#691) * save night mode in option cookie #676 (#692) * save night mode in option cookie #676 * moved add night-mode class to componentDidMount * fixed color of bismaalah for night mode * Fixes #681 API calls for reciter (#694) * Fixes #693 rerendering (#695) * Fixes #693 Rerendering on the client * ESlint * Fixes #686 Translations author name (#697) * Reduce nbsp spacing (#696) * added language in every api call (#699) * added language in every api call * fixed lint errors * React loadable (#701) * React Loadable for components * Eslint happy * Add Google Optimize (#706) * Fix pause toggle (#707) * Foot note (#710) * added foot note popup * lint happy * Fix non existant ayat (#708) * fix page when ayat not found * refactor previous commit * add translation for ‘chapter.index.ayatNotFound’ * fix typo * refactor verses checker * change key in translation * update ar translation * search improvement (#712) * search improvement * lint breaks * use text fonts for render page mode (#715) * Fix search no results and error (#720) * Separating audio files from verses api (#721) * Separating audio files from verses api * change reciter * remove dependency on audio from verses route * Settings on right drawer (#719) * Settings on right drawer * Settings looking good * Fixed cutting text and pr comments * Surah info SEO (#722) * Surah info SEO * Add full surah button * info server render * Sitemap * convert to id * Custom prop types (#726) * customPorpTypes.js file added that would hold all propType validations * custom props added to all components * Type folder removed * wrong imports were fixed * Fix staging (#731) * Fix search * Fixes #727 highlight word by word * Fixes #728 * ontop of master * Fixes #654 Verses dropdown (#724) * Fixes #654 Verses dropdown * default color for dropdown * fixed suggestion (#736) * fixed suggestion * fixed verse text for suggestion * don't load audio on search * disabled text based fonts (#739) * disabled text based fonts * disabled bot as well Google optimize flicker (#741) fixed reading mode (#746) * fixed reading mode * lint Merge branch 'production' of https://github.com/quran/quran.com-frontend * fixed missing range check * fixed range break Fix footer and player overlapping (#653) (#788) Merge branch 'master' of https://github.com/quran/quran.com-frontend Bug: listening first verse does not continue to the next. (#771) Fix webpack (#789) * eslint fixes * add BabiliPlugin * Add `-chunk` to prod config Merge branch 'master' of https://github.com/quran/quran.com-frontend added footer for pdf #780
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The state of the duration was never set to 1. Therefore, sometimes, it was calculating the progress bar as
NaNvalue, thus, the state never changed to call the next verse.