Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room name: @user:server.org and X others #522

Closed
aaronraimist opened this issue Mar 3, 2019 · 5 comments
Closed

Room name: @user:server.org and X others #522

aaronraimist opened this issue Mar 3, 2019 · 5 comments
Labels
invalid There's nothing to improve in Quaternion

Comments

@aaronraimist
Copy link
Member

Description

Since there is no room name for #tulirs-watercooler:half-shot.uk Quaternion calls the room @Corion:matrix.org, @Mike:matrix.org, @Trinity:matrix.org, and 159 other(s). It would be nice if there was a better name for these kinds of rooms

screen shot 2019-03-03 at 11 33 27 am

There is also no main address/canonical alias so Riot just picks one and uses that as the room name
screen shot 2019-03-03 at 11 37 12 am

Version information

  • Quaternion version: 0.0.9.4-beta1
  • Install method: .dmg
  • Platform: macOS 10.14.3
@aaronraimist aaronraimist added the bug/fix Quaternion doesn't work as expected label Mar 3, 2019
@KitsuneRal
Copy link
Member

KitsuneRal commented Mar 5, 2019

Well, what should I say - Riot goes against the spec recommendations:

Clients SHOULD NOT use m.room.aliases events as a source for room names, as it is difficult for clients to agree on the best alias to use, and aliases can change unexpectedly.

I'm not sure if Quaternion should follow suit and undermine this recommendation further.

@KitsuneRal KitsuneRal added enhancement A feature or change request for Quaternion and removed bug/fix Quaternion doesn't work as expected labels Mar 5, 2019
@aaronraimist
Copy link
Member Author

aaronraimist commented Mar 5, 2019

Ah :(

Yeah I don't know. Probably not.

@KitsuneRal
Copy link
Member

With that said - I understand that the current representation in Quaternion is suboptimal; let's bring it to spec people and see what they have to say.

@aaronraimist
Copy link
Member Author

element-hq/element-web#7323 Is the Riot issue

@KitsuneRal
Copy link
Member

After getting rid of m.room.aliases event and incorporating MSC688 the updated spec text still says that clients should avoid using non-canonical aliases to calculate the display name; and I think that's the best way forward, as we officially wrote non-canonical aliases off as untrusted.

@KitsuneRal KitsuneRal added invalid There's nothing to improve in Quaternion and removed enhancement A feature or change request for Quaternion labels Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid There's nothing to improve in Quaternion
Projects
None yet
Development

No branches or pull requests

2 participants