From 77e79059b5a5426f0f51622b12822a4d99583d27 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Sat, 1 Jun 2024 01:34:59 +0100 Subject: [PATCH] Core: `Unexpected test after runEnd` is now an error Deprecated warning was added in 2.17.0. Ref https://github.com/qunitjs/qunit/issues/1377. Ref https://github.com/qunitjs/qunit/pull/1629. --- src/test.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/test.js b/src/test.js index 4114ee79b..edb7355fc 100644 --- a/src/test.js +++ b/src/test.js @@ -63,10 +63,7 @@ export default function Test (settings) { // (Meaning the CI would pass despite the late-failing test). // Ref https://github.com/qunitjs/qunit/issues/1377 if (config.pq.finished) { - // TODO: Make this an error in QUnit 3.0 - // throw new Error( 'Unexpected test after runEnd. To report errors, consider calling QUnit.onUncaughtException() instead.' ); - Logger.warn('Unexpected test after runEnd. This is unstable and will fail in QUnit 3.0.'); - return; + throw new Error( 'Unexpected test after runEnd. To report errors, consider calling QUnit.onUncaughtException() instead.' ); } if (!this.skip && typeof this.callback !== 'function') { const method = this.todo ? 'QUnit.todo' : 'QUnit.test';