Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.0 rises error on insertEmbed() usage like in Medium example #1064

Closed
artaommahe opened this issue Oct 20, 2016 · 1 comment
Closed

1.1.0 rises error on insertEmbed() usage like in Medium example #1064

artaommahe opened this issue Oct 20, 2016 · 1 comment

Comments

@artaommahe
Copy link

artaommahe commented Oct 20, 2016

Quill 1.1.0 rises error on insertEmbed() usage like in Medium editor example

  let range = quill.getSelection(true);
  quill.insertEmbed(range.index, 'image', {
    alt: 'Quill Cloud',
    url: 'http://quilljs.com/0.20/assets/images/cloud.png'
  }, Quill.sources.USER);
  1. Visit example page http://codepen.io/quill/pen/qNJrYB?editors=0110
  2. Change used Quill version in settings to 1.1.0 (//cdn.quilljs.com/1.1.0/quill.core.js)
  3. Press run to update
  4. Open console
  5. Add new empty line and click add image action
  6. See error
Uncaught TypeError: Cannot read property 'position' of null

Expected behavior:
no error

Actual behavior:
error

Platforms:

Chromium version 53.0.2785.143 Built on Ubuntu , running on Ubuntu 16.04 (64-bit)

Version:

1.1.0

@jhchen jhchen changed the title 1.1.0 rises error on insertEmbed() usage like in Mediim example 1.1.0 rises error on insertEmbed() usage like in Medium example Oct 21, 2016
@jhchen
Copy link
Member

jhchen commented Oct 21, 2016

This is fixed in v1.1.1

@jhchen jhchen closed this as completed Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants